# De novo density assembly weights don't add up to a 100

2 posts / 0 new
De novo density assembly weights don't add up to a 100
#1

In the density guided de novo prediction script denovo_density.cc, there is this block of code here:

FragmentAssemblyMover::FragmentAssemblyMover() {
overlap_wt_ = 4.0;
clash_wt_ = 20.0;
close_wt_ = 6.0;
dens_wt_ = 0.85;  //fd

if ( option[ assembly_weights ].user() ) {
overlap_wt_ = option[ assembly_weights ]()[1];
clash_wt_ = option[ assembly_weights ]()[2];
close_wt_ = option[ assembly_weights ]()[3];
}

null_frag_ = option[ null_weight ]();
}

I wonder why the total weight doesn't add up to a 100 (4, 20, 6 and 0.85?). Why isn't there an option to specify density weight as well in the assembly_weights parameters? What is is "//fd", I understand it's a comment, what does it mean?

Post Situation:
Fri, 2018-08-03 12:07
fd is simply the initials of Frank DiMaio, the author of much fo the density fitting code.  People sometimes label lines of code with their initials to mark the fact that they're the ones responsible for it. It's somewhat unnecessary with the source control tools we have, but it acts like a logical validation rather than a technical one. -- Basically, "Frank was the one who set the value to 0.85, and in his opinion this is the best default value. (Please consult him if you change it permanently.)"